Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to No Nonsense FilePicker #76

Merged
merged 4 commits into from
May 18, 2018
Merged

Switch to No Nonsense FilePicker #76

merged 4 commits into from
May 18, 2018

Conversation

brarcher
Copy link
Owner

The codekidX storage-chooser was showing a number of issues found from users on Google Play. A simpler file picker is instead used which will helpfully be more stable.

This is to avoid a name conflict with using the
no nonsense filepicker in a future commit.
The codekidX file picker had some issues which occasionally
resulted in crashes. Some of these bugs have been reported
to the upstream project, but as the bug reports are from
Google Play not that much information was available to give.

The no nonsense file picker is used by the NewPipe app, and
it appears to be successful. Switching to it to hopefully
simplify the file selection process and make it more robust.
@licaon-kter
Copy link
Contributor

Will cover #61 too?

@brarcher brarcher merged commit 142104d into master May 18, 2018
@brarcher brarcher deleted the file-picker branch May 18, 2018 11:45
@brarcher
Copy link
Owner Author

Not just yet. If that behavior is configurable, it is not being used yet. That can be investigated after some miles are put onto the file picker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants